Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

47: Enable window flags with set -g @dracula-show-flags true. #75

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

spoulson
Copy link

@spoulson spoulson commented Oct 5, 2020

Enbolden window titles on activity or bell status. This is more readable, IMO, than the default reverse text, especially when window flags appear in different colors.

Enbolden window titles on activity or bell status.  This is more readable, IMO, than the default reverse text, especially when window flags appear in different colors.
@spoulson
Copy link
Author

spoulson commented Oct 5, 2020

This PR does the following:

  • Window flags opt-in with global option setting.
  • Displays window flags next to window name in the same manner as default tmux.
  • Flags are colored in purple to contrast the white text and remain less obtrusive to the eye.
  • Powerline and non-Powerline formatting considered.
  • Changed activity flag and bell flag formatting from "reverse" to "bold". This eliminates poor readability in reverse mode with different text colors that turn to different background colors. Bold will still stands out and does not affect coloring.

image

@ethancedwards8
Copy link
Member

This looks great! One thing I find a bit confusing is the zoom indicator. Is htop zoomed out? Is zsh normal? I think a simple + or - would suffice. I have some mixed feelings about the bold too. Also I think the - on the last selected window is a bad idea.

Overall this is great. Just fix those suggestions and I'd get this merged 👍

@spoulson
Copy link
Author

spoulson commented Oct 5, 2020

@ethancedwards8, I'm just using the standard window flags.

See: https://man.openbsd.org/OpenBSD-current/man1/tmux.1#STATUS_LINE

I could insert just the zoom indicator Z, but it was just as easy to insert all applicable window flags.

@ethancedwards8
Copy link
Member

I see, is there any way we could change those? I don't think they're very intuitive.

@spoulson
Copy link
Author

spoulson commented Oct 6, 2020

@ethancedwards8, I don't disagree, but that's standard tmux.

Maybe I can just keep with the scope of the issue and only put the Z flag for zoom. The other flags can be sorted out in a separate issue? I'm reluctant to jump to reengineering what's been in use for at least the last few years that I've been a tmux fan.

@ethancedwards8
Copy link
Member

That's fair, maybe @danerwilliams will have some input? I'm kind of on the fence.

@danerwilliams
Copy link
Member

@ethancedwards8 @spoulson imo we should probably just stick to standard tmux even if its not the most intuitive. Would rather conform to people's expectations.

@ethancedwards8
Copy link
Member

Okay sure thing, thanks for the PR @spoulson, I'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants