Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support diffAdded/diffRemoved syntax group #46

Closed
jtr109 opened this issue Oct 13, 2017 · 3 comments · Fixed by #62
Closed

Support diffAdded/diffRemoved syntax group #46

jtr109 opened this issue Oct 13, 2017 · 3 comments · Fixed by #62

Comments

@jtr109
Copy link

jtr109 commented Oct 13, 2017 •
edited
Loading

Description

Hi, there. The color scheme is awesome.

However, I met a problem when using $git commit -v. This command will show the difference between codes after my editing. The lines added are highlight. But the lines deleted display with the same color as normal lines, such as the screenshot below.

The key for its color is diffRemoved which linked to Special. And the color of Special is #f8f8f2.

I try to change it in my vimrc temporarily:

hi link diffRemoved DiffDelete
hi link diffAdded DiffAdd

Hope for more professional change in repository. Thanks a lot!

Versions

  • plugin version: 6a5bf34 (hash)
  • vim: NVIM v0.2.1-dev
  • git: 2.14.2

Screenshots

image
@jtr109 jtr109 changed the title An improvement of color for git commit --verbose An improvement request of color for git commit --verbose Oct 13, 2017
@jtr109 jtr109 changed the title An improvement request of color for git commit --verbose Support diffAdded/diffRemoved syntax group Oct 14, 2017
@benknoble
Copy link
Member

Would really like to see this supported—it's very easy to miss the diff-deleted lines currently. What does the change you mentioned look like?

@benknoble benknoble mentioned this issue Feb 16, 2018
Closed
@dsifford dsifford mentioned this issue Mar 23, 2018
Merged
dsifford added a commit that referenced this issue Mar 27, 2018
@dsifford
add git commit diff colors. closes #46
cfed316
@jtr109
Copy link
Author

jtr109 commented Mar 28, 2018

@benknoble Sorry for replying so late.

I am not very good at vim script. The code above just copy the style of DiffDelete and DiffAdd.

It looks like below.

image

@benknoble
Copy link
Member

@jtr109 No problem ! You should probably check out #62 though, as that will solve this issues by using more appropriate colors.

dsifford added a commit that referenced this issue Mar 28, 2018
@dsifford
Massive theme overhaul (#62)
5372185 
* progress on overhaul

* finish scrutinization of languages existing in old colors file

* remove markdown code block highlight due to broken upstream syntax

* add user config globals

* update issue and pull request templates

* small fixes

* fix "illegal value" error when using overrides

* actually fix the attribute filter this time

* add git commit diff colors. closes #46

* remove unnecessary duplicate

* set SignColumn explicitly

* Add a helpfile (#64)

* Ignore the tags file generated by :helptags

* Write the help file
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Massive theme overhaul dracula/vim
2 participants
@jtr109 @benknoble