Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dradis-nessus] Blank lines that contain spaces break code blocks and cause export errors #102

Closed
etdsoft opened this issue Mar 16, 2017 · 4 comments
Labels
Milestone

Comments

@etdsoft
Copy link
Member

etdsoft commented Mar 16, 2017

If the Nessus XML contains blank lines that actually contain a string of blank spaces, the code blocks will break within Dradis and cause errors on export.

The <plugin_output> tag of the Nessus XML may contain blocks of code. If these blocks contain lines that appear blank but are actually strings of empty spaces, these blank lines will import into Dradis and break the code blocks on export, causing errors like the one pictured below:

screen shot 2016-09-07 at 3 53 49 pm

The code block below will generate the error (above) when exported out of Dradis. If the lines that appear blank (e.g. the line before href="users [...]) are deleted and replaced with regular line breaks, the export error will disappear.

#[Description]#
bc.. 
-------- output --------
<td><a class="button" 

        href="users [...]
-------- vs --------
<td><a class="button" 

         href="dashboard [...]

        href="true [...]
------------------------

+ The parameter:

-------- output --------
<script type="text/javascript"></scrip [...]
                createCookie('userName', '', 365);
                createCookie('userLocale','en', 365);

                document.location.href = "/dashboard [...]
-------- vs --------
<script type="text/javascript"></scrip [...]
                createCookie('userName', '', 365);

                      document.location.href = "/systeminfo[...]
                    </script>The User [...]
------------------------

Bug initially reported by Keith

@rachkor
Copy link
Member

rachkor commented Oct 20, 2017

More details on this (closed) issue: https://github.com/securityroots/dradispro-tracker/issues/345

@etdsoft
Copy link
Member Author

etdsoft commented May 30, 2018

Fixed ships in next release.

@etdsoft etdsoft closed this as completed May 30, 2018
@etdsoft etdsoft added the bug label May 30, 2018
@etdsoft etdsoft added this to the v2.10 milestone May 30, 2018
@rachkor
Copy link
Member

rachkor commented Nov 14, 2018

Reopening as we had another instance of this exact error showing up in v3.0.0/v3.1.0.

@rachkor rachkor reopened this Nov 14, 2018
@aapomm
Copy link
Contributor

aapomm commented Nov 22, 2018

Fixed for v3.2.0

@aapomm aapomm closed this as completed Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants