Issue columns #14
Merged
Issue columns #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
etdsoft
commented
May 23, 2016
etdsoft
commented
- Detect the list of fields that the different Issues have and render all of them as columns in the Issues#index table.
- Allow the user to show/hide the different columns.
- Store the selection of columns in a per-user, per-project manner.
| @@ -21,8 +22,13 @@ class IssueTable | |||
| @$column_menu.find('a').on 'click', @onColumnPickerClick | |||
|
|
|||
| loadColumnState: => | |||
| # TODO: persist this in browser local storage or a cookie | |||
| @selectedColumns = ['title', 'tags', 'affected'] | |||
| if typeof(Storage) != "undefined" | |||
There was a problem hiding this comment.
You could just use coffeescript's existential operator here:
if Storage?
|
What about using cookie storage as a backup if there local storage is not supported by the browser? |
|
I just checked the browser support of localstorage and I think it wouldn't worth to implement a cookie based version as it is pretty widely supported: http://caniuse.com/#search=localstorage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.