Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __WinHttpHTML5FormAttribs for Au3Check #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seadoggie01
Copy link

Updated to have no issues with strictest Au3Check parameters: -d -w 1 -w 2-w 3 -w 4 -w 5 -w 6
Moved variable declarations to outside of loops and If statements

Updated to have no issues with strictest Au3Check parameters: -d -w 1 -w 2-w 3 -w 4 -w 5 -w 6
Moved variable declarations to outside of loops and `If` statements
@mlipok
Copy link

mlipok commented Apr 25, 2021

Some similar pr was here
#8

@seadoggie01
Copy link
Author

I see... I looked for pull requests, but not closed ones. 😒 I use the strict Au3Check settings and so I have to keep these changes. I might end up forking and maintaining a separate copy, ugh

@mlipok
Copy link

mlipok commented Apr 25, 2021

I know.
For the same reasons I use a modified UDF, because otherwise the projects that use it could not be implemented easily enough for me.

@seadoggie01
Copy link
Author

Per the wiki, it is best practice (in AutoIt) to declare variables outside of loops: https://www.autoitscript.com/wiki/Best_coding_practices#Scopes_of_Variables (near the end of the section)
Declaring inside loops has an impact on performance... albeit small

@mlipok
Copy link

mlipok commented Apr 26, 2021

Per the wiki, it is best practice (in AutoIt) to declare variables outside of loops: https://www.autoitscript.com/wiki/Best_coding_practices#Scopes_of_Variables (near the end of the section)
Declaring inside loops has an impact on performance... albeit small

I think that @dragana-r know this very well.
This can be "by desing/intentional usage ", but I do not know why.

rcmaehl added a commit to rcmaehl/autoit-winhttp that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants