-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XGROUP HELP crashes the server #854
Labels
Comments
romange
added a commit
that referenced
this issue
Apr 29, 2023
Along the way, performs small cleanups in command handling code. Fixes #854. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
added a commit
that referenced
this issue
Apr 29, 2023
Along the way, performs small cleanups in command handling code. XGROUP HELP is special because it falls out of Dragonfly command taxonomy design, where a command name determines where its key is located. All other XGROUP subcommands expect to see XGROUP <subcmd> <key> and this one obviously does not need any key. I fix it by working around the issue and introduce a dedicated dummy command for this combination. Fixes #854. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
added a commit
that referenced
this issue
Apr 29, 2023
Along the way, performs small cleanups in command handling code. XGROUP HELP is special because it falls out of Dragonfly command taxonomy design, where a command name determines where its key is located. All other XGROUP subcommands expect to see XGROUP <subcmd> <key> and this one obviously does not need any key. I fix it by working around the issue and introduce a dedicated dummy command for this combination. Fixes #854. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
romange
added a commit
that referenced
this issue
Apr 30, 2023
Along the way, performs small cleanups in command handling code. XGROUP HELP is special because it falls out of Dragonfly command taxonomy design, where a command name determines where its key is located. All other XGROUP subcommands expect to see XGROUP <subcmd> <key> and this one obviously does not need any key. I fix it by working around the issue and introduce a dedicated dummy command for this combination. Fixes #854. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description & Reproducing
Run Dragonfly, and send the
XGROUP HELP
command, which normally should list the availableXGROUP xyz
commands. Dragonfly (debug, optimized builds) then crashes, with the following output:System info
The text was updated successfully, but these errors were encountered: