fix: 'xgroup help' should show help message #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along the way, performs small cleanups in command handling code. XGROUP HELP is special because it falls out of Dragonfly command taxonomy design, where a command name determines where its key is located. All other XGROUP subcommands expect to see XGROUP <subcmd> <key> and this one obviously does not need any key. I fix it by working around the issue and introduce a dedicated dummy command for this combination. Fixes #854. Signed-off-by: Roman Gershman <roman@dragonflydb.io>
royjacobson
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the way, performs small cleanups in command handling code.
Fixes #854.