Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce
--replicaof
flag #1583introduce
--replicaof
flag #1583Changes from 17 commits
2d8ff28
1db5641
3e5c353
3fddec8
96f80ba
b99f112
d35fb4c
94cf293
baa2d34
a395703
1a3c1d5
674043f
0e3282f
cbe8d6c
841ccf2
677d2cb
89a49c9
d487e0e
9f640c3
c3ed691
cd6d730
f51837b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be a problem, in that after this function finishes the transaction will be concluded afterwards? Or is it ok to
Schedule()
an already concluded transaction?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that I am not too sure about, but I'm not sure I understand your concern? The logic of
FlushEntireDb
(orFLUSHDB
orDrakarys
..) schedules the transaction first and then executes it, which is fine.Are you worried that replication continues past the already-executed transaction?
Maybe @romange could chime in, I saw that he originally wrote this code 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried that transactions can't be used more than once, in which case maybe something unintended can happen after we flush the DB, when we try to use the tx again