Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce --replicaof flag #1583

Merged
merged 22 commits into from
Aug 9, 2023
Merged

introduce --replicaof flag #1583

merged 22 commits into from
Aug 9, 2023

Commits on Jul 23, 2023

  1. introduce --replicaof flag 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    2d8ff28 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into flag-replicaof 

    Signed-off-by: talbii <41526934+talbii@users.noreply.github.com>
    @talbii
    talbii authored Jul 23, 2023
    Configuration menu
    Copy the full SHA
    1db5641 View commit details
    Browse the repository at this point in the history

  3. fix pre-commit 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    3e5c353 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. fix build issues 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    3fddec8 View commit details
    Browse the repository at this point in the history

  2. Phrasing and renaming 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    96f80ba View commit details
    Browse the repository at this point in the history

  3. moved --replicaof flag calling logic to ServerFamily::Init(); int… 

    …roduce `ReplicaOfFlag`

Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    b99f112 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Some minor fixes 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d35fb4c View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. fix: Modify behaviour of --replicaof: always re-attempt connection … 

    …until `REPLICAOF NO ONE` is recieved

Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    94cf293 View commit details
    Browse the repository at this point in the history

  2. Improve readability of ReplicaOfInternal by using an enum 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    baa2d34 View commit details
    Browse the repository at this point in the history

  3. fix: Avoid snapshotting when supplied with --replicaof 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a395703 View commit details
    Browse the repository at this point in the history

  4. improved comments 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    1a3c1d5 View commit details
    Browse the repository at this point in the history

  5. chore: add regression testing for --replicaof 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    674043f View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. set Replicate() to return a bool, not through a pointer 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    0e3282f View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Improvements 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    cbe8d6c View commit details
    Browse the repository at this point in the history

  2. fix: Switch server state after initiating Replicate() 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    841ccf2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into flag-replicaof 

    Signed-off-by: talbii <41526934+talbii@users.noreply.github.com>
    @talbii
    talbii authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    677d2cb View commit details
    Browse the repository at this point in the history

  4. fix merge 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    89a49c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. revert changes to src/facade/reply_builder.cc 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    d487e0e View commit details
    Browse the repository at this point in the history

  2. more minor fixes 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    9f640c3 View commit details
    Browse the repository at this point in the history

  3. move NO ONE comparison to a function 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    c3ed691 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. final fixes, improve testing 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    cd6d730 View commit details
    Browse the repository at this point in the history

  2. adjustments 

    Signed-off-by: talbii <ido@dragonflydb.io>
    @talbii
    talbii committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    f51837b View commit details
    Browse the repository at this point in the history