bug: DFLY_PASSWORD environment variable deprecation #2539
Conversation
…he DFLY_requirepass environment variable. Otherwise use the DFLY_PASSWORD environment variable. Signed-off-by: Michael Primeaux <michael.primeaux@mac.com>
| @@ -123,7 +123,7 @@ spec: | |||
| - mountPath: /etc/dragonfly/tls | |||
| name: tls | |||
| env: | |||
| - name: DFLY_PASSWORD | |||
| - name: DFLY_requirepass | |||
There was a problem hiding this comment.
Can you add another test config (amnd golden file) for .Values.image.tag older than v1.14 so that we can verify the same?
Mostly looks good otherwise! :)
There was a problem hiding this comment.
Thanks for the review. I just pushed a commit that I believe addresses this request.
Signed-off-by: Michael Primeaux <michael.primeaux@mac.com>
|
Hi @mprimeaux we did release a new version a few hours ago so we got conflicting changes (sorry for that). Can I sincerely ask you to sync your fork and merge main. Also for convenience see the changes in: https://github.com/mprimeaux/dragonfly/commit/97982eef2cd4436bbc6fbe8e4e35327208191c39 If this is too much I am happy to take over :) |
|
Sure. I'll sync my fork. All good. |
Signed-off-by: Michael Primeaux <mprimeaux@users.noreply.github.com>
Signed-off-by: Michael Primeaux <michael.primeaux@mac.com>
|
@kostasrim Should be ready for a review. |
|
Thanks @mprimeaux for fixing the issue! I pushed some small nits around naming. Will merge it once the tests pass! |
* If the image.tag version is equal to 14.0.0 or greater then specify the DFLY_requirepass environment variable. Otherwise use the DFLY_PASSWORD environment variable. Signed-off-by: Michael Primeaux <michael.primeaux@mac.com> * Corrected version logic and added golden test Signed-off-by: Michael Primeaux <michael.primeaux@mac.com> * Updated golden file for TLS + image.tag Signed-off-by: Michael Primeaux <michael.primeaux@mac.com> * fix CI for chart linting test * rename new test specific to password * use v1.13.0 * update golden chart --------- Signed-off-by: Michael Primeaux <michael.primeaux@mac.com> Signed-off-by: Michael Primeaux <mprimeaux@users.noreply.github.com> Co-authored-by: Tarun Pothulapati <tarun@dragonflydb.io>
This PR addresses #2482. If the image.tag version is equal to 1.14.0 or greater then specify the DFLY_requirepass environment variable. Otherwise use the DFLY_PASSWORD environment variable.
The primary change I made was to
_pod.tpl; lines 94 through 100 here. The other files were modified as a result of executinggo test -v ./... -update.