-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move lint test chart to seperate action and trigger it on reg tests #2536
Conversation
kostasrim
commented
Feb 4, 2024
- move lint test chart to a separate action
- use it in regression tests
@Pothulapati what this step does? does it change release the new version of helm templates? |
@romange This test just runs the Helm Charts against a kubernetes cluster to make sure things work (using https://github.com/helm/chart-testing). I don't think this workflow releases a new file. Currently, Its failing on the Password Var deprecation and #2539 fixes that. |
Do you guys understand why some steps have |
@romange Not exactly sure why they exist but my guess would be that as they involve running a Kubernetes cluster they thought it was not necessary to run them per PR and only when they want but for runtime bugs (like the password one), It's the only way to find them is to run them. Considering that this new regression job runs on a schedule and on a trigger, I guess it makes sense to remove the toggle entirely and have this run everytime. wdyt? |
I agree, @kostasrim ^^ |
ct \ | ||
lint \ | ||
--config .ct.yaml \ | ||
${{github.event_name == 'workflow_dispatch' && '--all'}} ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept this because if the job gets triggered manually it will become true. I am not sure about the &&
-all` part, I am running the reg tests manually to see how it affects it and I will remove it if it's not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep we need it. see https://github.com/helm/chart-testing/blob/main/doc/ct_lint.md and --all