Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

bugfix:modify the words spelling mistakes #1133

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

Aresforchina
Copy link
Contributor

Ⅰ. Describe what this PR did

Increase the quality of articles and correct spelling mistakes

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)

do not need

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @Aresforchina
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Dragonfly, @Aresforchina
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/dragonflyoss/Dragonfly/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@codecov-io
Copy link

codecov-io commented Dec 12, 2019

Codecov Report

Merging #1133 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1133   +/-   ##
=======================================
  Coverage   47.22%   47.22%           
=======================================
  Files         116      116           
  Lines        7204     7204           
=======================================
  Hits         3402     3402           
  Misses       3535     3535           
  Partials      267      267
Impacted Files Coverage Δ
pkg/errortypes/supernode_errors.go 0% <ø> (ø) ⬆️
supernode/daemon/mgr/cdn/super_reader.go 22.61% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77febc...d33ea4c. Read the comment docs.

@Aresforchina Aresforchina changed the title fix typo modify the words spelling mistakes Dec 12, 2019
@Aresforchina Aresforchina changed the title modify the words spelling mistakes bugfix:modify the words spelling mistakes Dec 12, 2019
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Dec 12, 2019
Signed-off-by: Aresforchina <18845641183@163.com>
@allencloud
Copy link
Contributor

I found lots of such issue in this repo: https://github.com/dragonflyoss/Dragonfly/search?q=unknow&unscoped_q=unknow
Could you help to fix them all? @Aresforchina Thanks

@Aresforchina
Copy link
Contributor Author

@allencloud Of course, I'll fix them

@yunfeiyanggzq
Copy link
Member

@allencloud Of course, I'll fix them

any progress? if you want to fix them in other prs,I can merge this pr

@starnop
Copy link
Contributor

starnop commented Dec 16, 2019

LGTM.

any progress? if you want to fix them in other prs,I can merge this pr

@yunfeiyanggzq I don't think it's a good idea. We should fix the same problem in one PR as much as possible. 😄

@starnop starnop merged commit 39efe64 into dragonflyoss:master Dec 16, 2019
inoc603 pushed a commit to inoc603/Dragonfly that referenced this pull request Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
areas/typo kind/bug This is bug report for project size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants