This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
define the interface of seed #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm! |
xujihui1985
reviewed
Apr 15, 2020
wangforthinker
force-pushed
the
feat/define-seed-interface
branch
2 times, most recently
from
e52d6c2
to
f3603eb
Compare
lowzj
reviewed
Apr 16, 2020
wangforthinker
force-pushed
the
feat/define-seed-interface
branch
from
f3603eb
to
806439f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1286 +/- ##
=======================================
Coverage 49.73% 49.73%
=======================================
Files 120 120
Lines 7938 7938
=======================================
Hits 3948 3948
Misses 3666 3666
Partials 324 324 Continue to review full report at Codecov.
|
lowzj
reviewed
Apr 17, 2020
lowzj
reviewed
Apr 22, 2020
| // Seed describes the seed file which represents the resource file defined by taskUrl. | ||
| type Seed interface { | ||
| // Prefetch will start to download seed file to local cache. | ||
| Prefetch(perDownloadSize int64) (<-chan struct{}, error) |
There was a problem hiding this comment.
What's the meaning of perDownloadSize here?
There was a problem hiding this comment.
when a seed prefetch，perDownloadSize is the maximum size of concurrent downloading for a seed.
There was a problem hiding this comment.
Add taskID in BaseInfo.
Signed-off-by: allen.wq <allen.wq@alipay.com>
wangforthinker
force-pushed
the
feat/define-seed-interface
branch
from
5e75582
to
cb47003
Compare
Add it. |
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
Signed-off-by: Jim Ma <majinjing3@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allen.wq allen.wq@alipay.com
Ⅰ. Describe what this PR did
define the seed interface. See #1284.
Ⅱ. Does this pull request fix one issue?
NONE.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
No need.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews