Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

Add sbt support #14

Merged
merged 7 commits into from
Nov 23, 2016
Merged

Add sbt support #14

merged 7 commits into from
Nov 23, 2016

Conversation

kasecato
Copy link
Contributor

@kasecato kasecato commented Nov 22, 2016

@dragos
Copy link
Owner

dragos commented Nov 22, 2016

Thank you for your contribution! I'll have a look/try it out ASAP.

@dragos
Copy link
Owner

dragos commented Nov 23, 2016

When I try this locally within the debugger (F5 in VS Code) the language server wouldn't start. Do things work normally for you? Otherwise your changes look good. I'll leave it open a bit longer since you marked it as WIP.

@kasecato
Copy link
Contributor Author

@dragos

code -v #>=1.7.2
npm -v #>=3.10.8
node -v #>=v6.6.0

npm cache clean
rm -rf ~/.npm
rm -rf node_module
rm -rf out

npm install
npm run compile #or F5

F5

dragos-vscode-scala-sbt- 14

@kasecato kasecato changed the title [WIP]Add sbt support Add sbt support Nov 23, 2016
if (!cwd) {
cwd = workspace.rootPath;
}
args.splice(0, 0, 'sbt');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to run sbt just once, and pipe all the other commands in the running sbt instance? This would save some time, since sbt is slow to start.

@dragos
Copy link
Owner

dragos commented Nov 23, 2016

Thanks for the work, I'm happy to merge this. I think it would be great to reuse the Sbt instance if possible, but it can be a separate PR.

@dragos dragos merged commit 65f5842 into dragos:master Nov 23, 2016
@dragos
Copy link
Owner

dragos commented Nov 23, 2016

By the way, what did you use for the screencast? I think we could replace the one on the README page, it looks so and so.

@kasecato
Copy link
Contributor Author

Thank you👍
I'm using LICEcap, http://www.cockos.com/licecap/

@kasecato kasecato deleted the add/sbt branch November 23, 2016 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants