Forcing content type on the sendErrorResource the same way the sendResou... #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tartup. It is verified when sending the response.
drahak
added a commit
that referenced
this pull request
Jan 6, 2015
Forcing content type on the sendErrorResource the same way the sendResou...
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've run into the following problem - I am forcing the default contentType of API response by providing an explicit $contentType value to ResourcePresenter::sendResource($contentType).
However ResourcePresenter::sendErrorResource() method works differently and does not provide a way to force the content type and always relies on the Accept http headers only. This seems a bit unfortunate, thus I have prepared this pull request which unifies the way both methods work.
Btw, great library. :)