refactor traversal #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
force-pushed
the
bernhard-refactor-traversal
branch
from
4c136c4
to
f389b2d
Compare
KuabeM
reviewed
Jun 19, 2020
| P: AsRef<Path>, | ||
| { | ||
| let path = path.as_ref(); | ||
| let path = path.canonicalize().unwrap(); |
There was a problem hiding this comment.
Is unwrap() safe here, why not ??
There was a problem hiding this comment.
Canonicalize should only fail in https://doc.rust-lang.org/src/std/fs.rs.html#1847-1848 cases, so yes, this should be fixed at some point, but it does not hurt right now, since we check the metadata before we ever feed the path to this function, which guarantees it's either a file or directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
Changes proposed by this PR:
Fill in gaps in path traversal, required for #37 and #43