Use better way to skip falco events #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstemm
force-pushed
the
more-ef-drop-falco
branch
from
5eb7c7b
to
9d61ad1
Compare
Use the new method falco_consider() to determine which events to skip. This centralizes the logic in a single function. All events will still be considered if falco was run with -A. This depends on draios/sysdig#1105.
mstemm
force-pushed
the
more-ef-drop-falco
branch
from
24fedf0
to
0088ebc
Compare
test attribute all_events corresponds to the -A flag. Add for some tests that would normally refer to skipped events.
mstemm
force-pushed
the
more-ef-drop-falco
branch
from
097c034
to
197f876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new method falco_consider() to determine which events to
skip. This centralizes the logic in a single function.
This depends on draios/sysdig#1105.