32bit support broken?

[LocutusOfBorg]

Hello, looks like we have a regression between 0.26.4 and 0.26.7...
on armhf (32 bit arm), we are getting this error now:

Tue Jul 28 16:10:42 UTC 2020
make: Entering directory '/usr/src/linux-headers-5.4.0-42-generic'
  AR      /var/lib/dkms/sysdig/0.26.7/build/built-in.a
  CC [M]  /var/lib/dkms/sysdig/0.26.7/build/main.o
  CC [M]  /var/lib/dkms/sysdig/0.26.7/build/dynamic_params_table.o
  CC [M]  /var/lib/dkms/sysdig/0.26.7/build/fillers_table.o
  CC [M]  /var/lib/dkms/sysdig/0.26.7/build/flags_table.o
  CC [M]  /var/lib/dkms/sysdig/0.26.7/build/ppm_events.o
  CC [M]  /var/lib/dkms/sysdig/0.26.7/build/ppm_fillers.o
  CC [M]  /var/lib/dkms/sysdig/0.26.7/build/event_table.o
  CC [M]  /var/lib/dkms/sysdig/0.26.7/build/syscall_table.o
In file included from ./include/linux/list.h:9,
                 from ./include/linux/preempt.h:11,
                 from ./include/linux/spinlock.h:51,
                 from ./include/linux/seqlock.h:36,
                 from ./include/linux/time.h:6,
                 from ./include/linux/compat.h:10,
                 from /var/lib/dkms/sysdig/0.26.7/build/ppm_events.c:12:
/var/lib/dkms/sysdig/0.26.7/build/ppm_events.c: In function ‘parse_readv_writev_bufs’:
./include/linux/kernel.h:842:29: warning: comparison of distinct pointer types lacks a cast
  842 |   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
      |                             ^~
./include/linux/kernel.h:856:4: note: in expansion of macro ‘__typecheck’
  856 |   (__typecheck(x, y) && __no_side_effects(x, y))
      |    ^~~~~~~~~~~
./include/linux/kernel.h:866:24: note: in expansion of macro ‘__safe_cmp’
  866 |  __builtin_choose_expr(__safe_cmp(x, y), \
      |                        ^~~~~~~~~~
./include/linux/kernel.h:875:19: note: in expansion of macro ‘__careful_cmp’
  875 | #define min(x, y) __careful_cmp(x, y, <)
      |                   ^~~~~~~~~~~~~
/var/lib/dkms/sysdig/0.26.7/build/ppm_events.c:1251:19: note: in expansion of macro ‘min’
 1251 |      tocopy_len = min(iov[j].iov_len, (size_t)retval - bufsize);
      |                   ^~~
./include/linux/kernel.h:842:29: warning: comparison of distinct pointer types lacks a cast
  842 |   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
      |                             ^~
./include/linux/kernel.h:856:4: note: in expansion of macro ‘__typecheck’
  856 |   (__typecheck(x, y) && __no_side_effects(x, y))
      |    ^~~~~~~~~~~
./include/linux/kernel.h:866:24: note: in expansion of macro ‘__safe_cmp’
  866 |  __builtin_choose_expr(__safe_cmp(x, y), \
      |                        ^~~~~~~~~~
./include/linux/kernel.h:875:19: note: in expansion of macro ‘__careful_cmp’
  875 | #define min(x, y) __careful_cmp(x, y, <)
      |                   ^~~~~~~~~~~~~
/var/lib/dkms/sysdig/0.26.7/build/ppm_events.c:1252:19: note: in expansion of macro ‘min’
 1252 |      tocopy_len = min(tocopy_len, (size_t)targetbuflen - bufsize - 1);
      |                   ^~~
./include/linux/kernel.h:842:29: warning: comparison of distinct pointer types lacks a cast
  842 |   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
      |                             ^~
./include/linux/kernel.h:856:4: note: in expansion of macro ‘__typecheck’
  856 |   (__typecheck(x, y) && __no_side_effects(x, y))
      |    ^~~~~~~~~~~
./include/linux/kernel.h:866:24: note: in expansion of macro ‘__safe_cmp’
  866 |  __builtin_choose_expr(__safe_cmp(x, y), \
      |                        ^~~~~~~~~~
./include/linux/kernel.h:875:19: note: in expansion of macro ‘__careful_cmp’
  875 | #define min(x, y) __careful_cmp(x, y, <)
      |                   ^~~~~~~~~~~~~
/var/lib/dkms/sysdig/0.26.7/build/ppm_events.c:1254:19: note: in expansion of macro ‘min’
 1254 |      tocopy_len = min(iov[j].iov_len, targetbuflen - bufsize - 1);
      |                   ^~~
/var/lib/dkms/sysdig/0.26.7/build/ppm_fillers.c: In function ‘f_proc_startupdate’:
/var/lib/dkms/sysdig/0.26.7/build/ppm_fillers.c:932:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  932 |  res = val_to_ring(args, (uint64_t)current->comm, 0, false, 0);
      |                          ^
/var/lib/dkms/sysdig/0.26.7/build/ppm_fillers.c: In function ‘f_cpu_hotplug_e’:
/var/lib/dkms/sysdig/0.26.7/build/ppm_fillers.c:4592:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 4592 |  res = val_to_ring(args, (uint64_t)args->sched_prev, 0, false, 0);
      |                          ^
/var/lib/dkms/sysdig/0.26.7/build/ppm_fillers.c:4599:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
 4599 |  res = val_to_ring(args, (uint64_t)args->sched_next, 0, false, 0);
      |                          ^
  CC [M]  /var/lib/dkms/sysdig/0.26.7/build/ppm_cputime.o
  LD [M]  /var/lib/dkms/sysdig/0.26.7/build/sysdig-probe.o
  Building modules, stage 2.
  MODPOST 1 modules
ERROR: "__aeabi_uldivmod" [/var/lib/dkms/sysdig/0.26.7/build/sysdig-probe.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1644: modules] Error 2
make: Leaving directory '/usr/src/linux-headers-5.4.0-42-generic'

maybe some 64 bit division is not implemented in 32bit kernels? I don't really know what is going on...

[LocutusOfBorg]

the list of the failures, including build artifacts and logs are here:
https://autopkgtest.ubuntu.com/packages/s/sysdig/groovy/armhf

[kristopolous]

looks like there's 2 candidates for a low-touch solution: use do_div from div64 or somehow bring in the ASM from coreboot and link it accordingly ...

[LocutusOfBorg]

Looks like Ubuntu folks fixed it :)
http://launchpadlibrarian.net/493334325/sysdig_0.26.7-2ubuntu1_0.26.7-2ubuntu2.diff.gz

[LocutusOfBorg]

looks like not yet fixed in last release...

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[LocutusOfBorg]

ping?

[therealbobo]

Hi @LocutusOfBorg! As far as I know there never was the 32bit support 🤔 By the way the driver and libs moved in this repo: https://github.com/falcosecurity/libs !

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.