This repository has been archived by the owner on Jan 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d1f435
to
80262a8
Compare
Comment on lines
130
to
155
if (listings != null) { | ||
parameters.append("listings", listings.toString()) | ||
} | ||
if (entries != null) { | ||
parameters.append("entries", entries.toString()) | ||
} | ||
if (noGst != null) { | ||
parameters.append("noGst", noGst.toString()) | ||
} | ||
if (hq != null) { | ||
parameters.append("hq", hq.toString()) | ||
} | ||
if (statsWithin != null) { | ||
parameters.append("statsWithin", statsWithin.toString()) | ||
} | ||
if (entriesWithin != null) { | ||
parameters.append("entriesWithin", entriesWithin.toString()) | ||
} | ||
if (fields != null) { | ||
parameters.append("fields", fields.joinToString(",")) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would inline those ifs to have a more condensed view.
Also doesnt parameter cast to string internally anyway?
if (statsWithin != null) parameters.append( | ||
"statsWithin", statsWithin.toString() | ||
) | ||
|
||
if (entriesWithin != null) parameters.append( | ||
"entriesWithin", entriesWithin.toString() | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird line breaks
6f56c0f
to
4c953a1
Compare
This should maintain backwards-compatability with existing Java code
36054f2
to
13ef53b
Compare
SonarCloud Quality Gate failed.
|
13ef53b
to
d8dfbba
Compare
d8dfbba
to
3acbacc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getCurrentMarketBoardData
andgetMarketBoardSaleHistory
now acceptitemId: Int
oritemIds: Set<Int>
UniversalisException
now provides more information about the server-side exceptionAsync
functions