Move all functions to the top-level #35

drakon64 · 2023-08-20T22:02:35Z

Move all functions to the top-level
getCurrentMarketBoardData and getMarketBoardSaleHistory now accept itemId: Int or itemIds: Set<Int>
UniversalisException now provides more information about the server-side exception
Add overloads and checked exceptions for JVM Async functions

src/commonMain/kotlin/KtUniversalis.kt

rainbowdashlabs · 2023-08-20T23:20:42Z

src/commonMain/kotlin/KtUniversalis.kt

+            if (listings != null) {
+                parameters.append("listings", listings.toString())
+            }
+            if (entries != null) {
+                parameters.append("entries", entries.toString())
+            }
+            if (noGst != null) {
+                parameters.append("noGst", noGst.toString())
+            }
+            if (hq != null) {
+                parameters.append("hq", hq.toString())
+            }
+            if (statsWithin != null) {
+                parameters.append("statsWithin", statsWithin.toString())
+            }
+            if (entriesWithin != null) {
+                parameters.append("entriesWithin", entriesWithin.toString())
+            }
+            if (fields != null) {
+                parameters.append("fields", fields.joinToString(","))
+            }


I would inline those ifs to have a more condensed view.
Also doesnt parameter cast to string internally anyway?

src/commonMain/kotlin/KtUniversalis.kt

rainbowdashlabs · 2023-08-20T23:24:21Z

src/commonMain/kotlin/KtUniversalis.kt

+            if (statsWithin != null) parameters.append(
+                "statsWithin", statsWithin.toString()
+            )
+
+            if (entriesWithin != null) parameters.append(
+                "entriesWithin", entriesWithin.toString()
+            )
