re-natal upgrade fails with "Cannot read property 'length' of undefined"

[cldwalker]

Hi. While taking a look at luno-react-native I had the above error.

Steps to reproduce:

1. git clone luno-react-native to alwx/luno-react-native@122d541
2. re-natal upgrade

The failure seems to be coming from editing a non-existing file on older projects. This can be fixed by putting a file exists check before that line is invoked. Since that fn is called by multiple contexts, we may need to pass a boolean to patchReactNativePackager to check whether the file exists or not. Happy to submit a PR if you explain the approach you want.

For this particular case it would've been helpful if there was a stacktrace. Setting this event may help with that

Thanks for re-natal and look forward to using it more!

[drapanjanas]

Hi,
The Problem might be that npm dependencies are not installed after cloning, please use npm i
Also, luno was updated yesterday, you might try pulling latest changes and trying that. Also readme of luno now better describes steps how to have it running.

Thanks for proposal I like it. I think re-natal could benefit with the check that at least /node_modules folder not there, and similar checks. Stacktraces of unhandled errors also would be good. PRs are welcome.

[drapanjanas]

Should be fixed in v0.2.20

[cldwalker]

Thanks for the fix! 👍