Add note on Active Job integration for #663 #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like this should be automatically done by Draper itself. |
|
I agree that draper should take care of this. However, there is concern about this being misleading as the object won't be decorated when it is deserialized (#663). I'm proposing we solve this via code AND documentation. I'm awaiting a response on that issue to move forward. |
2 tasks
|
Closing this in favor of new pull request: Feature: ActiveJob Integration and Documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note about Active Job integration which causes Rails serializations issue when passing Draper decorated objects to Rails background mailers. This patch satisfies issue #663.