Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior in WP function unfolding #67

Closed
codyroux opened this issue Sep 20, 2019 · 2 comments
Closed

Inconsistent behavior in WP function unfolding #67

codyroux opened this issue Sep 20, 2019 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers WP Involves the Weakest Precondition computation

Comments

@codyroux
Copy link
Contributor

Right now, calling

bap foo --pass=wp --wp-inline=true

inlines nothing, since the wp-inline-funcs flag is not set and defaults to the empty list.

Similarly,

bap foo --pass=wp --wp-inline-funcs=foo

does not inline foo since the wp-inline flag is not set!

My feeling is that not specifying a wp-inline-funcs inlines everything rather than nothing, and that wp-inline-funcs should imply wp-inline.

@codyroux codyroux added bug Something isn't working WP Involves the Weakest Precondition computation labels Sep 20, 2019
@fortunac fortunac added the good first issue Good for newcomers label Sep 20, 2019
@fortunac
Copy link

Setting wp-file1 and wp-file2 should also imply wp-compare.

@fortunac
Copy link

fortunac commented Oct 1, 2019

Handled in #73

@fortunac fortunac closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers WP Involves the Weakest Precondition computation
Projects
None yet
Development

No branches or pull requests

2 participants