Inlining now takes a list of subroutines to inline, and uses summarie… #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortunac
reviewed
Aug 28, 2019
wp/lib/bap_wp/src/precondition.ml
Outdated
| @@ -465,12 +469,13 @@ let mk_inline_env | |||
| ?num_loop_unroll:(num_loop_unroll = !num_unroll) | |||
| ?exp_conds:(exp_conds = []) | |||
| ?arch:(arch = `x86_64) | |||
| ~subs:(subs : Sub.t Seq.t) | |||
| ~subs:(subs : Sub.t seq) | |||
| ~to_inline:(to_inline : Sub.t seq) | |||
There was a problem hiding this comment.
Not super important, but what's the difference between Seq.t and seq?
fortunac
reviewed
Aug 28, 2019
| @@ -1261,8 +1308,10 @@ let suite = [ | |||
| " >:: test_call_7; | |||
| "Test call with disabling function inlining SAT: \n\ | |||
| " >:: test_call_8; | |||
| "Test call with nested function inlining SAT: \n\ | |||
| "Test call with nested function inlining UNSAT: \n\ | |||
|
Looks good to me! |
fortunac
approved these changes
Aug 28, 2019
added 2 commits
August 29, 2019 10:43
|
Fixed! Feel free to merge if you want. |
|
Ah dang. |
codyroux
force-pushed
the
codyroux/inline-list
branch
from
52e20b5
to
da654a5
Compare
|
Ok fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s for the others