First PR! Started adding structure for the reddit object implementation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
reviewed
Apr 30, 2017
draw/reddit.dart
Outdated
| @@ -0,0 +1,9 @@ | |||
| // Provides the reddit class | |||
|
|
|||
| class reddit{ | |||
There was a problem hiding this comment.
Take a look at this page here for documentation styling: https://www.dartlang.org/guides/language/effective-dart/documentation. If we do it right, dartdoc automatically generates documentation pages when we upload the library to pub!
bkonyi
requested changes
Apr 30, 2017
draw/reddit.dart
Outdated
| @@ -0,0 +1,9 @@ | |||
| // Provides the reddit class | |||
|
|
|||
| class reddit{ | |||
There was a problem hiding this comment.
Please be sure to run dartfmt and analyzer on your code before submitting.
There was a problem hiding this comment.
Done, following was the output for dart analyser:
$ Analyzing [reddit.dart]...
$ No issues found
draw/reddit.dart
Outdated
| class reddit{ | ||
|
|
||
| //Reddit Constructor | ||
| reddit(){ |
There was a problem hiding this comment.
Typical style for Dart looks like this:
if (foo) {
// Note the space between the closing paren and opening brace.
}
…lar comments with adherence to dart docs.
bkonyi
reviewed
Apr 30, 2017
draw/reddit.dart
Outdated
| } | ||
| class reddit { | ||
| reddit() { | ||
| ///This is currently a placeholder for the Reddit Constructor. |
There was a problem hiding this comment.
Please always put a space before text in comments.
bkonyi
approved these changes
Apr 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Core Functionality
Yes
#Description
Added a draw folder to contain configuration and the reddit object implementation that will be exposed to users. Will also need some sort of folder for a replica of Model in praw. Recommending we keep configs in reddit.draw for now so that we can something up and running quickly. :)