Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First PR! Started adding structure for the reddit object implementation #1

Merged
merged 4 commits into from
Apr 30, 2017
Merged

First PR! Started adding structure for the reddit object implementation #1

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbffd7d
Added folder for reddit object to be exposed to user
ckartik Apr 29, 2017
1784d09
Moved comments to top of function to adhere to DART Style
ckartik Apr 30, 2017
ad9eddc
Swithed to full sentences and implmented doc comments instead of regu…
ckartik Apr 30, 2017
8176f8c
Ran dartfmt and dart analyser
ckartik Apr 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions draw/reddit.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Provides the reddit class

class reddit{
Copy link
Member

@bkonyi bkonyi Apr 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at this page here for documentation styling: https://www.dartlang.org/guides/language/effective-dart/documentation. If we do it right, dartdoc automatically generates documentation pages when we upload the library to pub!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to run dartfmt and analyzer on your code before submitting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, following was the output for dart analyser:
$ Analyzing [reddit.dart]...
$ No issues found


//Reddit Constructor
reddit(){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typical style for Dart looks like this:

if (foo) {
  // Note the space between the closing paren and opening brace.
}


}
}