Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle ffmpeg on Windows #1129

Open
leandro2222 opened this issue Aug 13, 2023 · 2 comments
Open

Bundle ffmpeg on Windows #1129

leandro2222 opened this issue Aug 13, 2023 · 2 comments
Labels
build Issues with building and distribution windows Windows-specific issue

Comments

@leandro2222
Copy link

leandro2222 commented Aug 13, 2023

Im using the v2.2 beta

BUG:
In the timeline player there is a 'export video' button.
In the 'export video' window the options mp4, webM and custom FFmpeg are not working with the error message:
"ffmpeg executable not found"

@leandro2222 leandro2222 changed the title Export timeline as video not working Export timeline as video not working + playback speed option request Aug 13, 2023
@leandro2222 leandro2222 changed the title Export timeline as video not working + playback speed option request Export timeline as video not working Aug 13, 2023
@askmeaboutlo0m
Copy link
Member

You mean the recording player. Yeah, we currently don't ship ffmpeg with the Windows version of Drawpile and installing it there manually for other programs to be able is, like so many things on Windows, a nightmare. So the solution would be for Drawpile to bring its own copy of ffmpeg along.

@askmeaboutlo0m askmeaboutlo0m changed the title Export timeline as video not working [2.2 Beta] Bundle ffmpeg on Windows Aug 13, 2023
@askmeaboutlo0m
Copy link
Member

Partially fixed by letting you pick the path to an ffmpeg executable now. If you try to run it and it can't find ffmpeg, it now tells you what you can do about it: download it from ffmpeg.org on Windows, install it via Homebrew on macOS and install it through the package manager on Linux.

But it would still be nicer if Drawpile just shipped with ffmpeg so you don't need to jump through this extra hoop.

image

@askmeaboutlo0m askmeaboutlo0m changed the title [2.2 Beta] Bundle ffmpeg on Windows Bundle ffmpeg on Windows Apr 6, 2024
@askmeaboutlo0m askmeaboutlo0m added windows Windows-specific issue build Issues with building and distribution and removed platform-specific labels Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues with building and distribution windows Windows-specific issue
Projects
None yet
Development

No branches or pull requests

2 participants