Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep a log of layer deletions and other significant actions #1135

Open
leandro2222 opened this issue Aug 16, 2023 · 3 comments
Open

Keep a log of layer deletions and other significant actions #1135

leandro2222 opened this issue Aug 16, 2023 · 3 comments
Labels
feature New features or improvements to existing ones

Comments

@leandro2222
Copy link

Layer operations should be logged in the session 'event logs', especially the 'delete layer' action.

@askmeaboutlo0m
Copy link
Member

The server can't log layer operations because it doesn't understand them, it's an opaque drawing command. But there isn't anything special about layer operations in the first place, if you don't want people to be able to edit a layer, remove the "general layer editing" permission or modify the layers' permissions.

@askmeaboutlo0m askmeaboutlo0m closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
@askmeaboutlo0m askmeaboutlo0m added feature New features or improvements to existing ones Won't Fix labels Aug 16, 2023
@askmeaboutlo0m
Copy link
Member

Actually, I thought about this while messing with the server implementation and I got the idea that these kinds of operations could be logged on the client instead. That doesn't require the server to understand opaque messages, but would still be useful for e.g. undoing an accidental deletion or something. So I'll reopen and retitle this in that regard.

@askmeaboutlo0m askmeaboutlo0m changed the title 'delete layer' action should be in session event logs Keep a log of layer deletions Sep 28, 2023
@MorrowShore
Copy link
Member

Would this issue be renamed to "Log Actions" instead with the new feature requests?

@askmeaboutlo0m askmeaboutlo0m changed the title Keep a log of layer deletions Keep a log of layer deletions and other significant actions Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or improvements to existing ones
Projects
None yet
Development

No branches or pull requests

3 participants