Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user cursors follow MyPaint brushes more closely #1178

Closed
amoruwu opened this issue Jan 16, 2024 · 3 comments
Closed

Make user cursors follow MyPaint brushes more closely #1178

amoruwu opened this issue Jan 16, 2024 · 3 comments
Milestone

Comments

@amoruwu
Copy link

amoruwu commented Jan 16, 2024

image

Something similar has been suggested on discord. I'm mostly here to place it for consideration of fixing the jittering for later And to suggest Giving 2.2 Brushes their own Receive delay option nevertheless of the jittering. Again for consistency! Also the lag and delay on 2.2 brushes

@amoruwu amoruwu changed the title Receive Delay on Mypaint brushes. (Feature/Usability?) Receive Delay on Mypaint brushes. (Feature/Usability) Jan 16, 2024
@askmeaboutlo0m askmeaboutlo0m changed the title Receive Delay on Mypaint brushes. (Feature/Usability) Make user cursors follow MyPaint brushes more closely Jan 17, 2024
@askmeaboutlo0m
Copy link
Member

This one is just visual smoothing, it's not related to any networking stuff like the receive delay is. Solution would be to actually recognize if the brush is jittering excessively and only smoothe out the cursor in that case, rather than doing it unconditionally and slowing down "normal" strokes for no reason.

@amoruwu
Copy link
Author

amoruwu commented Jan 17, 2024

Outside of recognizing when the slowing down might be actually be needed or not, I'm more suggesting giving 2.2 brushes their own Visual Smoothing value option like ' Receive Delay ' Or checkbox to turn it off and on. To have them consistent with other brushes or not up to the user. @askmeaboutlo0m

@askmeaboutlo0m
Copy link
Member

The algorithm has been replaced. Brushes without jitter should follow the cursor exactly now, brushes that do jitter should follow it faster than before.

@askmeaboutlo0m askmeaboutlo0m added this to the 2.2.2 milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants