Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session settings: remove "block new logins" option #1222

Open
askmeaboutlo0m opened this issue Apr 7, 2024 · 0 comments
Open

Session settings: remove "block new logins" option #1222

askmeaboutlo0m opened this issue Apr 7, 2024 · 0 comments
Labels
feature New features or improvements to existing ones

Comments

@askmeaboutlo0m
Copy link
Member

This option in the session settings keeps causing confusion. Some people abuse it to avoid setting a password, which is no longer necessary now that invite links include it. Some also think that it means that users who previosly joined the session can join again, but no, it just closes the session entirely.

Since the option is totally redundant with setting a password, we should just remove it altogether. If a user wants to close their session to new people joining, they can change the password and not tell anyone the new password.

The server still needs to handle old clients attempting to close the session and tell them to go set a password instead. New clients still need to handle old servers that have this option and present it in their UI if it's enabled, so that they can turn it off again. They should not be presented with it otherwise.

@askmeaboutlo0m askmeaboutlo0m added the feature New features or improvements to existing ones label Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or improvements to existing ones
Projects
None yet
Development

No branches or pull requests

1 participant