Fix nanosecond offset in TimeToString test #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Each audit record should be tagged with the timestamp > the packet was seen, in the format seconds.microseconds The TimeToString/StringToTime test's expected and actual timestamps were using different subsecond precisions (microseconds vs. time.Time's default nanoseconds) This commit dials the expected timestamp down to microsecond precision. - Before: 2018-12-24 23:23:45.323381814 +0100 CET - After: 2018-12-24 23:23:45.323381 +0100 CET
|
Good catch! Thanks :) |
ghost
deleted the
|
Well the test was failing for me so it stood out :) Thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TimeToString/StringToTime test's expected and actual timestamps
were using different subsecond precisions (microseconds vs. time.Time's
default nanoseconds)
This commit dials the expected timestamp down to microsecond precision.