Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad looking orange selection's bounding box when using the brush #31

Closed
DxUr opened this issue Aug 8, 2023 · 7 comments
Closed

Bad looking orange selection's bounding box when using the brush #31

DxUr opened this issue Aug 8, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@DxUr
Copy link

DxUr commented Aug 8, 2023

Godot version
4.1.1

its not the big problem I fix it by just just adding a holder node as a parent of paint_brush_node

replace this line :

owned_spatial.add_child(paint_brush_node)

with this:

var holder:Node = Node.new()
owned_spatial.add_child(holder)
holder.add_child(paint_brush_node)

@dreadpon
Copy link
Owner

dreadpon commented Aug 8, 2023

Could you please provide a screenshot to illustrate what you mean by "selection area" and "ugly"?

@DxUr
Copy link
Author

DxUr commented Aug 8, 2023

image
after fixing it:
image

@dreadpon
Copy link
Owner

dreadpon commented Aug 8, 2023

Weird that it works. Shouldn't the holder node account for selection's bounding box also?
I'll have to try it myself in my free time

@DxUr
Copy link
Author

DxUr commented Aug 8, 2023

as it is a node not a node3d

@dreadpon
Copy link
Owner

dreadpon commented Aug 8, 2023

Not sure how I feel about that. I'll have to research if it may cause potential problems with transforms and node hierarchy first...

@DxUr DxUr changed the title Bad looking orange selection erea when using the brush Bad looking orange selection's bounding box when using the brush Aug 8, 2023
@DxUr
Copy link
Author

DxUr commented Aug 8, 2023

I tested it, and it works perfectly.

@dreadpon dreadpon added the enhancement New feature or request label Aug 8, 2023
@dreadpon
Copy link
Owner

Looks good on my side, implemented in [9a4c89f].

@dreadpon dreadpon added this to the 1.4.0 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants