Cache the entry points discovered within a namespace #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scanning the entry point registry is relatively expensive and causes performance issues with unit tests of code depending on stevedore. This change addresses the performance issues by caching the entry points as they are loaded from pkg_resources in a class attribute in the base class of the extension managesr so they can be reused by other instances. Change-Id: Iba7bee6790cdedc94cb537e2ed6e12219c85f26a Signed-off-by: Doug Hellmann <doug.hellmann@dreamhost.com>
|
I've also sent this to Monty Taylor to review, so please don't merge until he's had a chance to look at it. |
markmcclain
added a commit
that referenced
this pull request
Nov 26, 2012
Cache the entry points discovered within a namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scanning the entry point registry is relatively expensive
and causes performance issues with unit tests of code
depending on stevedore. This change addresses the
performance issues by caching the entry points as
they are loaded from pkg_resources in a class attribute
in the base class of the extension managesr so they can
be reused by other instances.
Change-Id: Iba7bee6790cdedc94cb537e2ed6e12219c85f26a
Signed-off-by: Doug Hellmann doug.hellmann@dreamhost.com