feat(frontend): sidebar to show open bbb room #1080
Conversation
…tionDrawer components style: implement Figma design requirements for new components
…hensive Storybook examples and tests - Updated ListElement.vue to handle right content, icons, and images. - Added detailed Storybook stories for ListElement with text, icons, and images. - Fixed type issues in test files for ListElement, NavigationDrawer, and ListWithNavigationDrawer components. - Ensured all tests correctly type the wrapper variable as ReturnType<typeof mount>. fix: Ensure proper handling of right content and type safety in test files
ogerly
changed the title
mahula
changed the title
2024-06-1313-13-09-ezgif.com-crop-video.mp4 |
2024-06-1316-15-48-ezgif.com-crop-video.mp4 |
ogerly
changed the title
| background: transparent !important; | ||
| } | ||
|
|
||
| .top-menu { | ||
| position: sticky; | ||
| position: relative; |
There was a problem hiding this comment.
I understand you are still working on this, but still a remark here that sticky is important for the mobile menu, I believe, where only the TabControl stays visibile, and it should be sticky. Maybe you need relative only on desktop? Then the fix would be easy.
There was a problem hiding this comment.
ich habe dieses große PR in kleine PRs augeteilt. damit es übersichtlicher im review wird.
ich habe in der TopMenü alle meine änderungen die nicht meine aufgabe betrafen raus genommen.
von daher würde ich dich bitte meine anderen PRs mal anzusehen.
|
aufgeteilt in kleinere PRs Vuetify KomponentenDrawer: #1184 ListWithNavigationDrawer Komponentediese 3 vorhärigen PRs sind teil von folgenden PR: Top Menüdiese 4 vorhärigen 4 PRs sind teil von: |
🍰 Pullrequest
The GitHub pull request introduces two new elements, ListElement and ListWithNavigationDrawer, which are now available in Storybook for use. Additionally, it extends the TopMenu component. Here’s a summary of the main changes:
New Storybook Elements:
ListElement: A customizable list component with story examples for different item configurations.
ListWithNavigationDrawer: Combines a list with a navigation drawer, providing additional UI capabilities.
Extended TopMenu:
Enhancements to the TopMenu component, making it more versatile and user-friendly.
For more details, you can view the full changes on the GitHub PR page.
Next Steps:
a. Review and run the new Storybook elements to understand their functionality.
b. Integrate the new components into your application and test their interaction with existing elements.
Issues
Todo
ListElementandListWithNavigationDrawercomponents.