feat(frontend): 709 5 navigation drawer component #1185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Tirokk
changed the title
Mogge
reviewed
Jun 19, 2024
Mogge
reviewed
Jun 19, 2024
Mogge
requested changes
Jun 19, 2024
2 tasks
Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
Bettelstab
reviewed
Jun 20, 2024
Co-authored-by: Bettelstab <maxharz@gmail.com>
Bettelstab
requested changes
Jun 21, 2024
|
i have lowered the coverage of the branch by 1%. if this PR is the first to enter the master, all others of mine that currently still have a red tick should be green. |
Still the frontend linting check fails. |
|
I still think you should use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 5: NavigationDrawer Component
Name: NavigationDrawer Component
frontend/src/components/menu/NavigationDrawer.vue
frontend/src/components/menu/NavigationDrawer.stories.ts
frontend/src/components/menu/NavigationDrawer.test.ts
frontend/src/components/menu/snapshots/NavigationDrawer.test.ts.snap