fix: feature importance not dependent from dataloader #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eduardocarvp I've made a PR, with minimal changes. Can you review it? |
Optimox
force-pushed
the
fix/feature_importance
branch
from
4597a8b
to
5e25d68
Compare
|
Looks good to me! But I haven't tested yet (I'm not at home right now). But if you checked it's good it's ok for me. |
|
I think we need to make sure that results are the same as previously first... |
Optimox
force-pushed
the
fix/feature_importance
branch
from
5e25d68
to
f8eccea
Compare
Optimox
changed the title
eduardocarvp
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This is a bugfix that solves #371.
It also adds the ability to get individual explanations already normalized
Does this PR introduce a breaking change?
No.
Closing issues
closes #371