Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second part of fixes #3

Merged
merged 1 commit into from
May 8, 2015
Merged

Conversation

theAsmodai
Copy link
Collaborator

Fixed some Cmd_ functions, fixed messages sending in ClientPutInServer forward, added unrolled (un)munge2 functions, added one overflow check, fixed fullupdate spam from not active clients.

if (!frame->entities.entities)
{
frame->entities.num_entities = 256;
frame->entities.entities = (entity_state_t *)Mem_ZeroMalloc(sizeof(entity_state_t) * 256);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use some constant of #define instead of magic numbers

@dreamstalker
Copy link
Owner

Impressive! Thx for the PR!
Before I merge this I would ask you to squash all your commits into one, to avoid 'tons of commits' problem in the repo.

@theAsmodai theAsmodai force-pushed the master branch 3 times, most recently from 6fdb1c7 to 51f2a23 Compare May 7, 2015 17:55
…r forward, added unrolled (un)munge2 functions, added one overflow preventing check, fixed fullupdate spam from not active clients, removed entity states reallocation in SV_WriteEntitiesToClient, packing players states separately from entities, added defines.
@theAsmodai
Copy link
Collaborator Author

All done.

dreamstalker added a commit that referenced this pull request May 8, 2015
Fixed some Cmd_ functions, fixed messages sending in ClientPutInServer forward, added unrolled (un)munge2 functions, added one overflow preventing check, fixed fullupdate spam from not active clients, removed entity states reallocation in SV_WriteEntitiesToClient, packing players states separately from entities, added defines.
@dreamstalker dreamstalker merged commit 29aa669 into dreamstalker:master May 8, 2015
@deniska21233 deniska21233 mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants