Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

banning a user does not remove them from your profile #1279

Closed
rahaeli opened this issue Mar 4, 2015 · 6 comments
Closed

banning a user does not remove them from your profile #1279

rahaeli opened this issue Mar 4, 2015 · 6 comments
Assignees
@kaberett
Labels
status: claimed status: untriaged

Comments

@rahaeli
Copy link
Contributor

rahaeli commented Mar 4, 2015

Expected behavior (ie, the way LJ does it and the way I thought we did it too): when you ban a user from your journal, that account should no longer appear on your Subscribers/Has Access From lists.

Actual behavior: account still appears on your profile.

(This shouldn't affect the banned user's profile -- that is to say, if I susbcribe to Alice, and she bans me from her journal, my name should not appear on Alice's profile under 'Subscribers', but Alice's name should still appear on my profile as one of my subscriptions.)
@kareila
Copy link
Member

kareila commented Mar 4, 2015

Claiming

@kaberett
Copy link
Contributor

kaberett commented Mar 4, 2015

Yo Jen, if you're not super-invested in this one is there any chance I could nab it from you? I would find it Quite Cathartic for reasons and have some time I could spend on it this weekend ("no" is of course fine!).

@kareila
Copy link
Member

kareila commented Mar 4, 2015

Sure, I just figured I could do it quickly since I'm familiar with that code, but if you want first crack at it be my guest :)

@kareila kareila assigned kaberett and unassigned kareila Mar 4, 2015
@ninetyd
Copy link

ninetyd commented Mar 5, 2015

Related: http://dw-suggestions.dreamwidth.org/485089.html

@ninetyd
Copy link

ninetyd commented Mar 5, 2015

Also pretty sure this was a bug in Zilla somebody was working on or worked on at some point, possibly you, D, so there might so useful implementation notes.

@kareila
Copy link
Member

kareila commented Mar 5, 2015

You're right, @ninetyd, it was bug 3499. There was a patch submitted by @rahaeli which wasn't fully functional. Unfortunately, the email archives from Bugzilla don't include the submitted patches, but I can put up a copy of the surviving comments somewhere if that's helpful.

@kareila kareila mentioned this issue May 31, 2015
Merged
kaberett added a commit to kaberett/dw-free that referenced this issue May 31, 2015
@kaberett
Hide banned users from profile
7a16c46 
Fixes dreamwidth#1279

Prevents banned users from appearing on watch/trust/subscribe lists
on profile pages.
@afuna afuna closed this as completed in b70d1f5 Jun 7, 2015
afuna added a commit that referenced this issue Jun 7, 2015
@afuna
Merge pull request #1403 from kaberett/hide-banned-users-from-profile
fbe709e 
Hide banned users from profile (fixes #1279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaberett kaberett

Labels
status: claimed status: untriaged
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rahaeli @ninetyd @kareila @kaberett @robodw-issues