Hide banned users from profile (fixes #1279) #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents banned users from appearing in watch/trust/subscribe lists on profile pages.
| my %banned_users = map { $_ => 1 } @$banned; | ||
|
|
||
| # remove banned users from lists to display | ||
| @$_ = grep ( !defined $banned_users{ $_ }, @$_ ) |
There was a problem hiding this comment.
You probably want exists here instead of defined.
Also, our style is to use grep { } (with braces instead of parenthesis).
|
Fixes #1279. (This needs to be on a line by itself in a comment for Github to recognize it and close the issue when the PR is accepted.) |
Fixes dreamwidth#1279 Prevents banned users from appearing on watch/trust/subscribe lists on profile pages.
afuna
added a commit
that referenced
this pull request
Jun 7, 2015
Hide banned users from profile (fixes #1279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents banned users from appearing in watch/trust/subscribe lists
on profile pages. (Thanks Dre and Jen! <3)