cpp: Eliminate a buffer overflow in the tutorial server

Negative numbers can have 11 characters :) git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@758529 13f79535-47bb-0310-9956-ffa450edef68
dreiss · Mar 26, 2009 · b87a4d4 · b87a4d4
1 parent cedf71b
commit b87a4d4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/tutorial/cpp/CppServer.cpp b/tutorial/cpp/CppServer.cpp
@@ -69,8 +69,8 @@ class CalculatorHandler : public CalculatorIf {
 
     SharedStruct ss;
     ss.key = logid;
-    char buffer[11];
-    sprintf(buffer, "%d", val);
+    char buffer[12];
+    snprintf(buffer, sizeof(buffer), "%d", val);
     ss.value = buffer;
 
     log[logid] = ss;