-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some more tuya devices (switches) #3398
Conversation
@Smanar Could you link the issues to this PR? So they can close whenever they are finished? |
Its done, untested device are untested, so need to wait. |
@Smanar They don't show up on the linked issue list ;) |
If I link them, they will be closed, and battery is still not working for some of them, but not enought time for me ATM. |
de_web_plugin.cpp
Outdated
@@ -1850,6 +1852,7 @@ void DeRestPluginPrivate::addLightNode(const deCONZ::Node *node) | |||
else if ((i->inClusters()[c].id() == TUYA_CLUSTER_ID) && (node->macCapabilities() & deCONZ::MacDeviceIsFFD) ) { hasServerOnOff = true; } | |||
// Danalock support. The cluster needs to be defined and whitelisted by setting hasServerOnOff | |||
else if (node->nodeDescriptor().manufacturerCode() == VENDOR_DANALOCK && i->inClusters()[c].id() == DOOR_LOCK_CLUSTER_ID) { hasServerOnOff = true; } | |||
else if (node->nodeDescriptor().manufacturerCode() == VENDOR_NONE && i->inClusters()[c].id() == DOOR_LOCK_CLUSTER_ID) { hasServerOnOff = true; } //Kwikset 914 ZigBee smart lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When comparing for VENDOR_NONE please always include !node->nodeDescriptor().isNull()
check, otherwise this triggers a false positive if the node descriptor hasn't been queried yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found 2
Few modifications on core, just adding some devices
Untested