Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more tuya devices (switches) #3398

Merged
merged 19 commits into from Oct 15, 2020
Merged

Some more tuya devices (switches) #3398

merged 19 commits into from Oct 15, 2020

Conversation

Smanar
Copy link
Collaborator

@Smanar Smanar commented Oct 11, 2020

Few modifications on core, just adding some devices

Untested

@Mimiix Mimiix mentioned this pull request Oct 12, 2020
@Mimiix
Copy link
Collaborator

Mimiix commented Oct 12, 2020

@Smanar Could you link the issues to this PR? So they can close whenever they are finished?

@Smanar
Copy link
Collaborator Author

Smanar commented Oct 12, 2020

Its done, untested device are untested, so need to wait.
For other still missing something (like battery), but the rest is working.

@Mimiix
Copy link
Collaborator

Mimiix commented Oct 13, 2020

@Smanar They don't show up on the linked issue list ;)

@Smanar
Copy link
Collaborator Author

Smanar commented Oct 13, 2020

If I link them, they will be closed, and battery is still not working for some of them, but not enought time for me ATM.

@@ -1850,6 +1852,7 @@ void DeRestPluginPrivate::addLightNode(const deCONZ::Node *node)
else if ((i->inClusters()[c].id() == TUYA_CLUSTER_ID) && (node->macCapabilities() & deCONZ::MacDeviceIsFFD) ) { hasServerOnOff = true; }
// Danalock support. The cluster needs to be defined and whitelisted by setting hasServerOnOff
else if (node->nodeDescriptor().manufacturerCode() == VENDOR_DANALOCK && i->inClusters()[c].id() == DOOR_LOCK_CLUSTER_ID) { hasServerOnOff = true; }
else if (node->nodeDescriptor().manufacturerCode() == VENDOR_NONE && i->inClusters()[c].id() == DOOR_LOCK_CLUSTER_ID) { hasServerOnOff = true; } //Kwikset 914 ZigBee smart lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When comparing for VENDOR_NONE please always include !node->nodeDescriptor().isNull() check, otherwise this triggers a false positive if the node descriptor hasn't been queried yet.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found 2

@manup manup merged commit 6250d8b into dresden-elektronik:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants