Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodically poll SwBuildId for IKEA, OSRAM and Philips #3498

Merged
merged 1 commit into from Oct 26, 2020

Conversation

manup
Copy link
Member

@manup manup commented Oct 24, 2020

Due OTA updates the version attribute may change.

Due OTA updates the version attribute may change.
@ebaauw
Copy link
Collaborator

ebaauw commented Oct 24, 2020

Wouldn’t it be enough to be reading these on device announcement? From what I’ve seen, devices tend to reboot after firmware update.

What about the descriptors and the other Basic attributes? These tend to change on firmware updates as well.

@manup
Copy link
Member Author

manup commented Oct 26, 2020

Good point, I guess after an update it makes sense to query all static attributes and descriptors again to be sure. For the new Device state machine that's rather easy, after certain events like update finished or device announce. For now I'd like to avoid bringing more complexity in the "old" code. The PR queries on an per hour basis, not optimal but hopefully shouldn't hurt, it also updates SwBuildId for devices which were OTA updated in the past but never queried automatically afterwards (like OSRAM and Philips).

@manup manup merged commit 3615a24 into dresden-elektronik:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants