Improve HTTP accept header parsing of API versions; Reintroduce colorcapabilities in API version v1.1 #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always pick the largest supported version; - Support headers with multiple versions; - To add more versions simply extend the array. The `getAcceptHeaderApiVersion()` is a pure function for easier testing later on.
For clients with v1.0 this won't be a breaking change and colorcapabilities still returns a number. Clients which support v1.1 need to support colorcapabilities as array. Related PR dresden-elektronik#3642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve HTTP accept header parsing of API versions
The
getAcceptHeaderApiVersion()is a pure function for easier testing later on.Reintroduce colorcapabilities in API version v1.1
For clients which support
vnd.ddel.v1or don't provide an API version this won't be a breaking change andcolorcapabilitiesstill returns a number. Clients which supportvnd.ddel.v1.1need to supportcolorcapabilitiesas array.Related PR #3642