Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sengled E1E-G7F #4275

Closed
wants to merge 1 commit into from

Conversation

MoshiBin
Copy link

See #3308

@SwoopX
Copy link
Collaborator

SwoopX commented Jan 26, 2021

See #4264 and #4235 from a couple of days ago 😄

@MoshiBin
Copy link
Author

Yeah, I was definitely over-eager 😅
At least I got to poke around the code and understand a little more about zigbee and deCONZ

@MoshiBin MoshiBin closed this Jan 26, 2021
@MoshiBin
Copy link
Author

By the way, the above PRs do not fix de_web_plugin.cpp - the Sengled switch sends the button number as the payload. Without this part all buttons were being identified as the top button.

@SwoopX
Copy link
Collaborator

SwoopX commented Jan 26, 2021

Ah, yeah, you're right. Took me a little while to get what you mean. Since it's a new cluster to consider, the already available code doesnt cater for that. Good catch!

@kyletpugh
Copy link

Was this fully merged? Has the pressing any button results in only the top button event been resolved? The switch works but only generates the event for the first button single press no matter what you press.

@Mimiix
Copy link
Collaborator

Mimiix commented Feb 12, 2021

@kyletpugh Depending on your version, it is.
Check Swoops PR :)

@kyletpugh
Copy link

Which version has fully working behavior? I have version 2.09.03. I am using the beta channel, looks like this change is there but does not produce the correct results.

@SwoopX
Copy link
Collaborator

SwoopX commented Feb 12, 2021

Please open a dedicated issue for this and provide logs with info level 2. The latest stable and beta contain the required code.

@kyletpugh
Copy link

The above comments say that all buttons are recognized as the first single press because something else needed changed. The PR is closed with unmerged changes. I am confirming that every button results in being mapped to first button single press.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants