Add initial support for Tuya siren - #4379
Merged
Merged
Conversation
manup
requested changes
Feb 15, 2021
manup
left a comment
manup
left a comment
Member
There was a problem hiding this comment.
I've added a few comments. Can you please have a look, I think this PR needs to wait for a 2.10.1 release in roughly a week.
manup
reviewed
Feb 22, 2021
manup
reviewed
Mar 3, 2021
| } | ||
| quint8 valve = static_cast<quint8>(dp & 0xFF); | ||
| quint8 temperature = static_cast<quint8>((dp >> 8) & 0xFF); | ||
| quint8 minute = static_cast<quint8>((dp >> 16) & 0xFF); // TODO, U16 >> 16 ... this is always 0?! |
Member
There was a problem hiding this comment.
In that case I wouldn't add it to the PR or at least comment it out with a note what it is and why it isn't used.
In general I'm very against adding dead code since usually it stays there for years with nobody having a clue why it's there and everybody afraid of removing it ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manufacture name : _TYST11_d0yu2xgi issue #3183
It s a USB or battery siren https://zigbee.blakadder.com/Neo_NAS-AB02B0.html
This device create 3 sensors, ZHAAlarm + ZHAhumidity + ZHAtemperature.
All settings are on the ZHAAlarm (melody, volume, trigger, ect ...)
The threshold need to be set with Array [min, max], need to improve it.