Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IKEA KADRILJ and FYRTUR roller blind reporting #4818

Merged
merged 6 commits into from
Apr 30, 2021

Conversation

manup
Copy link
Member

@manup manup commented Apr 27, 2021

The reporting could stop when the device rejoins the network for various reasons like parent loss or transmission errors.

This PR:

  • Marks KADRIL and FYRTUR roller blinds as light sleeper with the new non public ResourceItem "attr/sleeper" (borrowed from Device code);
  • Support polling light sleeper Window Covering devices state.lift while reporting isn't setup;
  • Fix window covering update by ZCL report / read attributes value (was always set to by report);
  • Fix reconfiguration of window covering bindings and ZCL reporting.

Issue: #1121

Backuported Device code, this item can be set to false to overule rxOnWhenIdle and note that the device is always listening (for example IKEA KADRILJ roller blind and Philips motions sensor).
The value was shadowed and always set to report. This prevents the binding report configuration to properly work.
- Default init numericValue to zero;
- Cache lightNode->modelId().
Don't treat as rxOnWhenIdle: false device.
Will be excecuted only brifly while reporting isn't configured yet. This also has the side effect that reporting will be configured/repaired.
@manup manup requested a review from ebaauw April 27, 2021 10:34
@manup manup added this to the v2.11.2-beta milestone Apr 27, 2021
Copy link
Collaborator

@ebaauw ebaauw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have the FYRTUR, but I understand the FYRTUR and KADRILJ are the same Zigbee device, with the same firmware, except for the Model Identifier and the Product Code.

Same logic might be opportune for the Aqara B1.

@manup manup changed the title Fix IKEA KADRILJ roller blind reporting Fix IKEA KADRILJ and FYRTUR roller blind reporting Apr 27, 2021
@manup
Copy link
Member Author

manup commented Apr 27, 2021

Cool, thanks I've extended the PR to handle both.

@manup manup merged commit 7af4178 into dresden-elektronik:master Apr 30, 2021
@zigomatichub
Copy link

Hello, I don't know if this is the right place to post.
About the FYRTUR, in deconz application, on the cluster info in container Window Covering of the node, the value Current Position Lift Percentage is not updated after executing a exec command.
Is it possible to expose the reported position value in home assistant as an entity and having then refreshed correctly ?

@manup manup deleted the feature_kadril_reporting branch January 3, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants