Disable IAS zone status reporting for Samjin Button #4986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should, in conjunction with PR #4765, prevent 1002 ghost events.
In #4232, it has been suggested to manually disable attribute reporting for IAS zone status to prevent the unwanted events. This has been reported not to be effective. Apparently, this was due to the fact that the code to trigger any attribute reporting configuration disrespects the value for disablement and consequently "resets" and re-configures reporting.
With this PR, attribute reporting will always be set to "disabled" upon reoccurring configuration thereby ensuring persistence. This is primarily intended to prevent any re-paring of the device.