DDF add Ubisys C4 #5661
Merged
DDF add Ubisys C4 #5661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call checkSensorBindingsForClientClusters() only after the value has been updated.
Support "auto" group handling like for Kobold. Todo: [] check if device setup attribute needs to be written. The C++ version looks incomplete.
The button map requires the exact modelid, in the past C4 worked since we tested with startsWith().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C4 is currently broken for various reasons. The DDF is meant to replace the C++ implementation while being backward compatible. Group binding and reconfiguration of these works as for Kobold with the "auto"
config.groupsupport for all 4 endpoints.Initially with the DDF the C4 wil create 4 device groups and binds to them so that x002 button events are received right away.
The controlled groups can be reconfigured via REST API or within the Phoscon App switch details view. It might take a minute or two until the changes are applied.
TODO
Check the C++ implementation ofprocessUbisysC4Configuration()it looks incomplete, is it even needed?https://github.com/dresden-elektronik/deconz-rest-plugin/blob/master/bindings.cpp#L4496
Remove C++ code for C4The PR seems good to go, luckily could remove some unholy C++ stuff.
Tested with C4 firmware versions:
10F2-7B09-0000-0004-0107015E-ubisys-C4.ota
10F2-7B09-0000-0004-0192020D-spo-fmi4.ota1 → this version needs to be loaded before the next one!
10F2-7B29-0000-0004-01930221-spo-fmi4.ota
Final note the firmware now also supports a nice Sw Version attribute, Date Code is still 20170531-DE-FB1.