Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix battery updates not contributing to sensor availability #6974

Merged
merged 1 commit into from May 16, 2023

Conversation

SwoopX
Copy link
Collaborator

@SwoopX SwoopX commented May 14, 2023

For power_configuration.cpp, setting the resource item value is changed from resource::setValue() back to resourceItem::setValue(), as it was prior to version 2.13.0. This will ensure internal resource item timestamps are updated upon reception of an attribute report, even upon no value change.

In the end, this will prevent certain sensors to go into unreachable state and bring back some previously seen websocket events.

@SwoopX SwoopX added the Fix label May 14, 2023
@SwoopX SwoopX added this to the v2.22.1-beta milestone May 14, 2023
@SwoopX SwoopX linked an issue May 14, 2023 that may be closed by this pull request
@SwoopX SwoopX requested review from ebaauw and manup May 14, 2023 22:02
@manup manup merged commit 37ee64f into dresden-elektronik:master May 16, 2023
@SwoopX SwoopX deleted the battery_event_fix branch August 5, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Battery updates do not contribute to device availability
2 participants