Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: false water detection for lumi_sensor_wleak_aq1 #7091

Merged
merged 5 commits into from Jul 20, 2023
Merged

Bug fix: false water detection for lumi_sensor_wleak_aq1 #7091

merged 5 commits into from Jul 20, 2023

Conversation

ebaauw
Copy link
Collaborator

@ebaauw ebaauw commented Jul 7, 2023

Remove state/water_bis as Xiaomi special attribute doesn't always reflect the water detected state, see #7061

Remove `state/water_bis` as Xiaomi special attribute doesn't always reflect the water detected state, see #7061
@ebaauw ebaauw added this to the v2.23.0-beta milestone Jul 7, 2023
@ebaauw ebaauw requested a review from manup July 7, 2023 11:27
@ebaauw ebaauw added the Device Improvement Additional tag to attach to a existing issue. label Jul 7, 2023
@ebaauw
Copy link
Collaborator Author

ebaauw commented Jul 18, 2023

Hm, removing state/water_bis causes state/lastupdated no longer to be updated. There are no other state items in the Xiaomi special attribute, and the IAS Zone doesn't support Supervision reports. Looking at the legacy code, state/lastupdated is updated from the Xiaomi special attribute.

Just doing a dummy update of state/water to the current value seems to do the trick.

Note that I haven't had a false positive on my sensor with firmware 0.0.0_0006, but I've seem plenty on my sensor with firmware 0.0.0_0004.

@manup
Copy link
Member

manup commented Jul 20, 2023

Interesting approach :) if it works we should give it a try.

@ebaauw
Copy link
Collaborator Author

ebaauw commented Jul 20, 2023

Interesting approach

I suppose that's as good a description as any ;-)

if it works we should give it a try.

Been running this on my test environment for two days now, and state/lastupdated is updated as intended.

@manup manup merged commit f2399d8 into dresden-elektronik:master Jul 20, 2023
1 check failed
@ebaauw ebaauw deleted the leak branch July 20, 2023 18:13
@dxa13
Copy link

dxa13 commented Sep 11, 2023

Hi Erik @ebaauw , I tried using your fix with the 2.23.0 beta branch, and my one leak sensor with firmware 0.0.0_0004 (all other 9 I have have firmware 6) is still reporting a false leak (from issue #7061). Is that expected behavior after the fix, or is something just remembering the last state? Is there a way to force the false leak go away or be cleared (i.e. update the state) without physical interaction with the sensor (i.e. shorting the leads, or having to re-pair it)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device Improvement Additional tag to attach to a existing issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xiaomi Aquara Water leak sensor (SJCGQ11LM) falsely reports trouble on deConz 2.22.2 (HA addon)
3 participants