Fix macOS opening of button maps file #7131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… work with a branch
…to continue working on the master
|
I've just checked the compiled bundle, no need for change the button_maps.json file is already copied to the correct location, due a higher level CMakeLists.txt. |
|
@manup This is not about the button_maps.json file itself, just the plugin's ability to locate the file, without this modification, the file isn't loaded and all the node's clusters are just Unknown (0) state. |
|
Ah damn missed it, yes that's correct thanks. |
manup
changed the title
manup
pushed a commit
that referenced
this pull request
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the macOS button_maps.json file location on the app bundle